Track supporting DPKG evidence #3228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
commented
Sep 12, 2024
| pkg.NewLicenseFromLocations("GPL-1", file.NewVirtualLocation("/usr/share/doc/libpam-runtime/copyright", "/usr/share/doc/libpam-runtime/copyright")), | ||
| pkg.NewLicenseFromLocations("GPL-2", file.NewVirtualLocation("/usr/share/doc/libpam-runtime/copyright", "/usr/share/doc/libpam-runtime/copyright")), | ||
| pkg.NewLicenseFromLocations("LGPL-2.1", file.NewVirtualLocation("/usr/share/doc/libpam-runtime/copyright", "/usr/share/doc/libpam-runtime/copyright")), | ||
| pkg.NewLicenseFromLocations("GPL-1", file.NewLocation("/usr/share/doc/libpam-runtime/copyright")), |
There was a problem hiding this comment.
Can you help me understand why this stopped being a virtual location and became a regular location? Is this change visible to users in the eventual SBOM?
There was a problem hiding this comment.
This was cleanup -- since I was in this file and making new Locations, I noticed that all params to the original call were the same, which is the same as using the NewLocation constructor. So I made the remaining parts of the file that were using this function needlessly as consistent as the new code I was adding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This elevates supporting locations on each package to be expressed with
evident-byrelationships --today we only do this with primary locations. This additionally adds a new 'kind' param to the relationship data, showing if this is 'primary' or 'supporting' evidence.This helps with #3191 since now these files would be accounted for by a package (without claiming they are owned by it), thus, it will no longer show up as an unknown when #2998 lands.
Closes #3191