Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pre-release integration PRs #3370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make pre-release integration PRs #3370

wants to merge 3 commits into from

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Oct 22, 2024

This updates the existing stereoscope workflow into a generic "update anchore deps" workflow, leveraging the work done in anchore/workflows#11 . This adds a new task that can be used as so:

# update stereoscope from the tip of main
make update-anchore-dependencies FROM=main

# update stereoscope from the latest release relative to the goproxy
make update-anchore-dependencies FROM=latest

# update stereoscope from the tip of an integration branch
make update-anchore-dependencies FROM=integration

See an example run: #3372

@wagoodman wagoodman marked this pull request as draft October 22, 2024 19:31
@wagoodman wagoodman force-pushed the update-workflow branch 2 times, most recently from ddf37b2 to 1bb531f Compare October 22, 2024 20:02
@wagoodman wagoodman self-assigned this Oct 22, 2024
@wagoodman wagoodman force-pushed the update-workflow branch 2 times, most recently from 900ee52 to ab7f806 Compare October 22, 2024 21:08
@wagoodman wagoodman marked this pull request as ready for review October 22, 2024 21:09
vars:
- FROM
cmd: |
{{ .GH }} workflow run update-anchore-dependencies.yml -f repos="github.com/anchore/stereoscope@{{ .FROM }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this task be used for anything? Generally, I think the dependencies would be updated by dependabot once an upstream project has a new version released. If I'm making a change in syft, here, I would be most interested in testing this specific change across the downstream projects, namely: Grype.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when there are releases, yes. But this is also used to control integration branches too (update to commits without releases), something that dependabot can't do. This mechanism would happen to be used for both integration and main though during release trains.

@@ -0,0 +1,49 @@
name: PR to update Anchore dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this workflow just goes away, and there's a different workflow to run grype/validations.yml against a syft change in a syft PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to open these pre-release PRs as integration branches in all repos during a release day, starting with pointing at integration branches for all dependencies with the PR in a draft state, then once releases start (after all pre-release PRs are green) we bump all dependencies to released versions and promote the PR from draft to mergable.

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants