Fix relative symlinks handling in resolver.rs to retrieve resolv.conf #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04.1, the symlink is relative:
$ ll /etc/resolv.conflrwxrwxrwx 1 root root 39 Aug 27 17:37 /etc/resolv.conf -> ../run/systemd/resolve/stub-resolv.confwhich on current master fails with:
No such file or directory (os error 2)This fix resolves the relative path based on the symlink location, not cwd.
It also improves errors in this area, as finding out what file or directory was missing, considering no other context at all in logs or otherwise, was quite a challenge.