Bugfix: define plugin.error and reject any unknow type parameter in addStatement #450
Conversation
|
See #402 |
| @@ -501,10 +507,6 @@ SQLitePluginTransaction.prototype.addStatement = function(sql, values, success, | |||
| } else if (t === 'boolean') { | |||
| //Convert true -> 1 / false -> 0 | |||
| params.push(~~v); | |||
| } | |||
There was a problem hiding this comment.
@halaei why did you remove this conditional block? wouldn't it suffice to implement warn function instead...it appears that warn function is the one that is missing...
Also, the missing plugin method was warn rather than error ?
There was a problem hiding this comment.
@andpor Maybe I was thinking of backward compatibility or to keep the behavior as strict as possible to minimize possible errors. I don't see any value to silently save {x: {}} as "[object Object]". It just makes things more complicated in handling errors. I don't know what will happen when we save symbols or any other types.
Maybe both error and warn was missing, but warn wasn't used anywhere except the code that I removed.
I did this PR a while ago and don't remember all the details. I guess you have already fixed the issue in some other way.
Currently passing an object or function as parameter causes an unhandled exception, without calling error callbacks or rejecting promise. The reason is that, on such inputs, an undefined function
plugin.error()/plugin.warn()is called.Reading the code, it was expected to accept anything other than functions, but this PR reject objects as well, because it is more consistent with the current behaviour, and I think such inputs should be regarded as invalid anyway.
PS: my editor automatically removes extra spaces from some irrelevant lines. Sorry about that.