Support for devices that show extra information in the model

[badnetmask]

The SureHA integration reports devices in the following format:

Manufacturer: Sure Petcare
Model: Feeder (XXXX-XXXXXXX)

Where XXXX-XXXXXXX is the device's serial number.
As I can see in your code, it only supports exact matches on the model names.
Is there a chance to add support for wildcard or regexes?

PS: I have manually added mine for the time being, so no rush on this.

[andrew-codechimp]

I am really trying to avoid regex's as I don't want to end up writing them for people with these devices that don't have a proper model and I'm not sure if a simple wildcard would cover all permutations.

The correct way would be for the integration not to have this in the model, or use the new model ID being introduced in HA 2024.8.
Maybe raise an issue with the integration saying model should be model only for this reason?

I am rewriting the library lookup at the moment which may make it easier to add pattern matching in future but I do wonder how much I should bend for badly designed integrations, I'll keep coming back to this one I'm sure.

[badnetmask]

I totally understand. Would you mind providing some links to the HA references, so I can open a bug report with them?

[andrew-codechimp]

And this got me thinking more, regex is overkill but an optional json schema addition for the library might be an easy way of handling this. No promises when but I like this idea.

 "model_match_method": {
      "type": "string",
      "description": "The matching method for model, default exact.",
      "enum": ["startswith", "endswith", "contains"]
  }

[andrew-codechimp]

I have just put version 2.4.x into beta which adds support for this (you'll need to have chosen to add betas via HACS to see it)
If you want to add your device via a PR it should work, I've been using it with Apple device wildcards here
Or just supply me the battery type/quantity and I can add it.

[badnetmask]

Sure. Let's try that. Please see #1935.

[andrew-codechimp]

Thanks, just merged it. A HA restart or maybe an integration reload will pull the library down.

[badnetmask]

Working as expected! Thanks!

[andrew-codechimp]

Great, thanks for confirming. Was good to finally cover this use case.