-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All schedules generated by plugin start from 00 : 00 #89
Comments
This is happening for me as well. Creating the task: - [ ] 08:00 - 10:00 This is a test ⏳ 2024-07-23 The time is being lost somehow. |
Same when I create a task - [ ] 9:30 - 10:30 Test ⏳ 2024-07-31 and push it to my gist the Ical properties state: BEGIN:VEVENT I have Day Planner enabled and checked the integration option in the Obsidian to ical plugin. When I open my daily note and type in the same thing as above (- [ ] 9:30 - 10:30 Test ⏳ 2024-07-31) the Day Planner recognizes it. |
Hi everyone, I fixed this problem by modifying the source code in At line 4000 or so, add method after the
at line about 3843, modify the code into this:
and now this plugin recognize the Day planner format by default. The generated
I'm considering make a pull request, but I dont know how to test my code in my forked repo...Can anyone tell me how to do? |
Thanks for the source code @JeffeyChou. I implemented your code into my Obsidian Vault and it mostly works around (85% of the time for my tasks). However, the code seems to not recognize events before 10:00am. Example: BEGIN:VEVENT vs. BEGIN:VEVENT I did some debugging on the source code (main.js) in the plugin itself and to fix this you need to change the line right after function getTimeFromSummary(): const timeRegex = /(\d{2}:\d{2})(?:\s*-\s*(\d{2}:\d{2}))?/; to const timeRegex = /(\d{1,2}:\d{2})(?:\s*-\s*(\d{1,2}:\d{2}))?/ Now it works for me on 100% of the cases. |
Hi @ChrisRule01 , thank you for your kind reminder! I noticed such bugs in my test file, I make a more general timeRegex and it works. The problem you mentioned lies in that the original Regex can't recognize AM/PM format, I make adjustment in my code, and make a pull request to this repo. It should work now. |
All schedules generated by plugin start from 00 : 00 ,i have write time ues the format HH:mm in the task ,but all schedules start from 00:00
The text was updated successfully, but these errors were encountered: