Mark Chrome as reliably fillable and saveable (#1338)

* Mark Chrome as reliably fillable and saveable * Mention Autofill improvements in CHANGELOG (cherry picked from commit 6206850)
android-password-store · Mar 6, 2021 · cdc198d · cdc198d
1 parent eff07d1
commit cdc198d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 
+-   Autofill now works much more reliably in Chrome 89 and later, including support for saving passwords if no accessibility service is enabled.
 -   Editing a password allowed accidentally overwriting an existing one
 
 

diff --git a/.../src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt b/.../src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt
@@ -146,6 +146,7 @@ private val BROWSER_SAVE_FLAG = mapOf(
 
 @RequiresApi(Build.VERSION_CODES.O)
 private val BROWSER_SAVE_FLAG_IF_NO_ACCESSIBILITY = mapOf(
+    "com.android.chrome" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
     "com.chrome.beta" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
     "com.chrome.canary" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
     "com.chrome.dev" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
@@ -181,7 +182,6 @@ fun getBrowserAutofillSupportInfoIfTrusted(
 }
 
 private val FLAKY_BROWSERS = listOf(
-    "com.android.chrome",
     "org.bromite.bromite",
     "org.ungoogled.chromium.stable",
     "com.kiwibrowser.browser",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.

		### Fixed

		- Autofill now works much more reliably in Chrome 89 and later, including support for saving passwords if no accessibility service is enabled.
		- Editing a password allowed accidentally overwriting an existing one


Expand Down