Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use Github working directory #160

Open
joergi opened this issue Mar 19, 2024 · 0 comments
Open

Feature: use Github working directory #160

joergi opened this issue Mar 19, 2024 · 0 comments

Comments

@joergi
Copy link

joergi commented Mar 19, 2024

In GitHub Actions you can use working directory:

documentation

This is an example, how it should look like

jobs:
  a-job-name:
    runs-on: ubuntu-latest
    defaults:
      run:
        working-directory: ./apache-beam-dependency-problem

but later in the file existence check, I have to repeat the working directory for the file existence check

   - name: "Check file existence linux"
        id: check_files
        uses: andstor/file-existence-action@v3.0.0
        with:
          files: "./apache-beam-dependency-problem/build/install/apache-beam-dependency-problem/lib/beam-runners-direct-java-2.53.0.jar"
          fail: true

These examples are from here

there should be a possibility to say: use working_dir yes or no.

I would love to see the example working like this:

   - name: "Check file existence linux"
        id: check_files
        uses: andstor/file-existence-action@v3.0.0
        with:
          files: "./apache-beam-dependency-problem/build/install/apache-beam-dependency-problem/lib/beam-runners-direct-java-2.53.0.jar"
          fail: true
          working_dir: true

Readme.md should look like this:

Input variable Necessity Description Default
files Required Comma separated string with paths to files and directories to check for existence. Supports glob paterns.
ignore_case Optional Ignore if a file name has upper or lower cases. true
follow_symbolic_links Optional Indicates whether to follow symbolic links. true
fail Optional Makes the Action fail on missing files. false
working_dir Optional Uses the github working directory. false

It would make sense to have the working_dir set as a standard to true but this would let all existing file checks fail, that's why I would set it default to false.

I was trying to look if I could implement it myself, but I was missing the skills to do it in TypeScript

this could also maybe closes issue #150

joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
joergi added a commit to joergi/file-existence-action that referenced this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant