Replace Node.js 16 with Node.js 20 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thank you 😊 |
|
👋 I'm curious why this needed to be a new major version release? |
|
👋 @andyw8 I might have been a bit too conservative on the versioning. As it seems that all the action runners provided by GitHub now supports Node.js 20, we could probably have gotten away with simply a patch version. Though, it is technically a breaking change. At least for self-hosted runners. However, one could debate if it is the responsibility of the action or the self-hosted users to avoid environment-related breaking changes. |
CharlesChiuGit
pushed a commit
to ayamir/nvimdots
that referenced
this pull request
Jan 30, 2024
see andstor/file-existence-action#144 Signed-off-by: Cyberczy <109653523+Cyberczy@users.noreply.github.com>
misumisumi
pushed a commit
to misumisumi/nvimdots
that referenced
this pull request
Mar 5, 2024
see andstor/file-existence-action#144 Signed-off-by: Cyberczy <109653523+Cyberczy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
According to GitHub Actions migration guide, this is the only step that we need to take to move from Node.js 16 to Node.js 20
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-using-nodejs-v20
On top I have updated deprecated dependencies