Fix platform firmware and UEFI capsule builds when cross compiling #265
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must ensure we are using `flash-tools` for the build platform when we are using it during a build (i.e. not on a machine performing the flashing at "runtime").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We must ensure we are using
flash-toolsfor the build platform when we are using it during a build (i.e. not on a machine performing the flashing at "runtime").This change fixes the immediate issue of some of the
packagesflake outputs not building (since we cross compile them), however there is some good future work that can be done to re-organize these derivations where we can justcallPackagethem and automatically get the rightflash-tools.Testing
Tested against internal test suite as well as tested the fixed flake outputs for uefi capsule updating and initrd flashing for an orin-nx devkit.