refactor: minimize session data

andygeiss · Jan 5, 2025 · 02ebf37 · 02ebf37
1 parent 9a9048c
commit 02ebf37
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/security/oauth_callback.go b/security/oauth_callback.go
@@ -33,8 +33,6 @@ func OAuthCallback(homePath string, sessions *ServerSessions) http.HandlerFunc {
 		// Update the user's session.
 		id := sessions.Update(ServerSession{
 			AvatarURL: userInfo.AvatarURL,
-			EMail:     userInfo.EMail,
-			Login:     userInfo.Login,
 			Name:      userInfo.Name,
 		})
 
@@ -100,8 +98,6 @@ func getAccessToken(code string) (string, error) {
 // githubUserInfo represents the user's information returned by the GitHub API.
 type githubUserInfo struct {
 	AvatarURL string `json:"avatar_url"`
-	EMail     string `json:"email"`
-	Login     string `json:"login"`
 	Name      string `json:"name"`
 }
 

diff --git a/security/server_sessions.go b/security/server_sessions.go
@@ -9,8 +9,6 @@ import (
 type ServerSession struct {
 	ID        string `json:"id"`
 	AvatarURL string `json:"avatar_url"`
-	EMail     string `json:"email"`
-	Login     string `json:"login"`
 	Name      string `json:"name"`
 }
 

diff --git a/security/server_sessions_test.go b/security/server_sessions_test.go
@@ -9,13 +9,13 @@ import (
 
 func TestServerSessions_Update(t *testing.T) {
 	sessions := security.NewServerSessions()
-	id := sessions.Update(security.ServerSession{AvatarURL: "avatar_url", EMail: "email", Login: "login", Name: "name"})
+	id := sessions.Update(security.ServerSession{AvatarURL: "avatar_url", Name: "name"})
 	assert.That(t, "id is correct", len(id), 64)
 }
 
 func TestServerSessions_Get(t *testing.T) {
 	sessions := security.NewServerSessions()
-	session := security.ServerSession{AvatarURL: "avatar_url", EMail: "email", Login: "login", Name: "name"}
+	session := security.ServerSession{AvatarURL: "avatar_url", Name: "name"}
 	id := sessions.Update(session)
 	session.ID = id
 	current, found := sessions.Get(id)