Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Player interface doesn't distinguish between local and remote players #639

Open
vixalien opened this issue Mar 31, 2024 · 3 comments
Labels
bug An issue that is confirmed as a bug needs design A project that needs design UI/UX An issue that affects the user interface or experience

Comments

@vixalien
Copy link
Contributor

Current Behavior

When I pair & connect Valent to my Android device running KDE Connect on my phone, I can view players exposed by Valent through the KDE Connect protocol.

The issue is that when I open Valent on my PC, it also sees players from the phone.

Let me explain this in more detail by giving an example,

on my phone (KDE Connect)

I have two apps playing music:

  • YouTube Music
  • Apple Music

on my PC (Valent)

I have one app playing music:

  • Muzika

Observation

On my phone, I will see the two players (YouTube Music & Apple music) + the one exposed by Valent (Muzika)

If I go on my PC, Valent will see three players from the Android phone, i.e. YouTube Music, Apple Music & Muzika. Note that it sees Muzika as a player from the phone, even though it's a player from itself.

Expected Behavior

I woud expect only the sources from the app to be shown (not other sources exposed by KDE Connect on the phone)

Desktop

GNOME Shell

Other Desktop

No response

Operating System

Alpine

Installed from

Nightly Flatpak

Version

1.0.0.alpha

Devices

KDE Connect (Android)

Plugins

No response

Logs

No response

Screenshots

No response

@vixalien vixalien added the triage An issue that needs confirmation and labeling label Mar 31, 2024
@andyholmes
Copy link
Owner

andyholmes commented Mar 31, 2024

How can you tell it's seeing Muzika as a player from the phone? Wouldn't that mean you should have 4 players on your desktop?

@andyholmes andyholmes added needs info An issue that needs more information and removed triage An issue that needs confirmation and labeling labels Mar 31, 2024
@vixalien
Copy link
Contributor Author

When I click on the player from the GNOME panel, I'm taken to a screen which shows players exposed by Valent.

It shows: Google, YouTube Music and Muzika.

The Muzika source is actually exposed by KDE Connect on the mobile phone.

@andyholmes
Copy link
Owner

Ah, that's a list of all media players known to Valent, including local players. Probably we should clarify that in the user interface then.

@andyholmes andyholmes changed the title Valent sees it's own MPRIS players from other devices Media Player interface doesn't distinguish between local and remote players Mar 31, 2024
@andyholmes andyholmes added bug An issue that is confirmed as a bug UI/UX An issue that affects the user interface or experience needs design A project that needs design and removed needs info An issue that needs more information labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that is confirmed as a bug needs design A project that needs design UI/UX An issue that affects the user interface or experience
Projects
None yet
Development

No branches or pull requests

2 participants