Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on y ticks for QC plots #386

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Turn on y ticks for QC plots #386

merged 4 commits into from
Jul 13, 2023

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #378. QC plots need to have corresponding y-ticks because the scaling for each channel is different.

How did you implement your changes

Remove any setting in visualize_qc_metrics where yticks or yticklabels are set to [].

@alex-l-kong alex-l-kong marked this pull request as draft June 30, 2023 22:19
@alex-l-kong alex-l-kong marked this pull request as ready for review July 12, 2023 21:38
@alex-l-kong alex-l-kong self-assigned this Jul 12, 2023
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the output look like now?

@alex-l-kong
Copy link
Contributor Author

alex-l-kong commented Jul 13, 2023

@ngreenwald here's an example plot (non-zero mean intensity):

Non-zero mean intensity_barplot_stats

@ngreenwald ngreenwald merged commit 25f1c6d into main Jul 13, 2023
4 checks passed
@ngreenwald ngreenwald deleted the qc_yaxis branch July 13, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qc_metrics plots don't have axis labels
4 participants