-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOV resolution check #391
FOV resolution check #391
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple usability questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's better to put this FOV resolution check directly after the 3a
and 3b
notebooks, since we'd want to verify that the resolution is correct right after image extraction.
If you're really feeling it, you could potentially even add it to the fov_watcher
(full pipeline) and bin_extraction
(just extraction) as well.
Agreed, we'll discuss at pipeline today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one addition
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #388. Calculates the image resolution for each FOV using
frameSizePixels[width]
/fovSizeMicrons
and outputs them for the user to check.How did you implement your changes
Add a function
check_fov_resoltutions()
which retrieves the information from the run file and calculated the resolution for each FOV.Print resolutions in the notebook and have a save_path arg if the user would like to specify a file to save to.
Example notebook output:
Remaining issues