Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

Angular strict dependency injection #106

Open
maitredede opened this issue Sep 4, 2015 · 2 comments
Open

Angular strict dependency injection #106

maitredede opened this issue Sep 4, 2015 · 2 comments

Comments

@maitredede
Copy link

Hi,

Module is not written for strict dependency injection :

https://docs.angularjs.org/guide/di

Directive declaration should become :
.directive('uiCodemirror', ["$timeout", "uiCodemirrorConfig", uiCodemirrorDirective])

@i4got10
Copy link

i4got10 commented Oct 7, 2015

👍

bower package has minified version with annotations(via ng-annotate), npm package has not.

@ostruk
Copy link

ostruk commented Oct 7, 2015

👍
Took me a while to figure out why it was crashing on production.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants