Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/divider): move unthemable tokens to theme mixin #27881

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(material/divider): move unthemable tokens to theme mixin #27881

merged 1 commit into from
Oct 19, 2023

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 3, 2023 •
edited
Loading

Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3)

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Oct 3, 2023
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Oct 3, 2023
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2023
@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Oct 14, 2023
@mmalerba mmalerba added this to the 17.0.0 milestone Oct 14, 2023
@mmalerba mmalerba force-pushed the divider-unthemables branch from e142ec3 to 082dc68 Compare October 19, 2023 04:14
@mmalerba mmalerba removed the request for review from andrewseguin October 19, 2023 04:26
@mmalerba
fix(material/divider): move unthemable tokens to theme mixin
696e8d5 
Though these tokens are not currently affected by the theme, in the
future they will be affected by the design system used for theming (M2
or M3)
@mmalerba mmalerba force-pushed the divider-unthemables branch from 082dc68 to 696e8d5 Compare October 19, 2023 04:27
@angular-robot angular-robot bot requested a review from crisbeto October 19, 2023 04:28
@angular-robot angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label Oct 19, 2023
jelbourn
jelbourn approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba removed the request for review from crisbeto October 19, 2023 04:31
@mmalerba mmalerba merged commit 9535454 into angular:main Oct 19, 2023
16 checks passed
mmalerba added a commit that referenced this pull request Oct 19, 2023
@mmalerba
fix(material/divider): move unthemable tokens to theme mixin (#27881)
c6fa905 
Though these tokens are not currently affected by the theme, in the
future they will be affected by the design system used for theming (M2
or M3)

(cherry picked from commit 9535454)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
17.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @jelbourn @crisbeto