Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimizations to button-base #27949

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Minor optimizations to button-base #27949

merged 1 commit into from
Oct 19, 2023

Conversation

esprehn
Copy link
Contributor

@esprehn esprehn commented Oct 16, 2023

Use vararg version of classList.add which has been allowed since cac8359

also don't use a loop to check the attribute, it's only ever a single thing.

@esprehn esprehn requested a review from andrewseguin as a code owner October 16, 2023 18:37
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Oct 19, 2023
@crisbeto crisbeto self-assigned this Oct 19, 2023
@crisbeto crisbeto added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Oct 19, 2023
@crisbeto crisbeto merged commit f8c6b40 into angular:main Oct 19, 2023
17 of 18 checks passed
crisbeto pushed a commit that referenced this pull request Oct 19, 2023
@esprehn @crisbeto
rafactor(material/button): minor optimizations to button-base (#27949)
defd48d 
Use vararg version of classList.add which has been allowed since cac8359

also don't use a loop to check the attribute, it's only ever a single thing.

(cherry picked from commit f8c6b40)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esprehn @crisbeto