refactor(youtube-player): simplify component internals #27951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `youtube-player` component was set up to use long rxjs chains everywhere which made it difficult to reason about and unnecessarily complex. This complexity would've prevented us from adding new features to it. These changes reduce the component by ~30% while preserving its behavior and making it easier to reason about.
crisbeto
added
P3
crisbeto
added a commit
that referenced
this pull request
Oct 17, 2023
The `youtube-player` component was set up to use long rxjs chains everywhere which made it difficult to reason about and unnecessarily complex. This complexity would've prevented us from adding new features to it. These changes reduce the component by ~30% while preserving its behavior and making it easier to reason about. (cherry picked from commit 3cbf125)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
youtube-playercomponent was set up to use long rxjs chains everywhere which made it difficult to reason about and unnecessarily complex. This complexity would've prevented us from adding new features to it.These changes reduce the component by ~30% while preserving its behavior and making it easier to reason about.