Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fixes issue #697. Text is now visible properly in vocab match game #1390

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devanshi7799
Copy link

Description

I have made changes in the activity_vocab_match_game.xml file. I have simply added padding value to keep the text at the centre of the image

Fixes #697

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have tested this on two android devices(vivo y51l and micromax HS2) and it works perfectly fine

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

75097340-aac74a00-55cf-11ea-9ac4-8d283679d5e2
75097339-a864f000-55cf-11ea-9ed3-1f9597a2fa04

android:gravity="center"/>
android:gravity="center"
android:paddingLeft="@dimen/vocam_match_padding"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write line no 83 in the following way: android:paddingLeft="@dimen/vocam_match_padding" />
Always try to avoid the use of extra lines.

Copy link
Contributor

@pknotfound pknotfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devanshi7799
Is there a typo in this?
I think it should be @dimen/vocab_match_padding instead of @dimen/vocam_match_padding?
What do you think?

@devanshi7799
Copy link
Author

@Priyansh-Kedia Oh , I might have misspelled it. Thanks for pointing it out :)

@pknotfound
Copy link
Contributor

@Priyansh-Kedia Oh , I might have misspelled it. Thanks for pointing it out :)

Happy to help

@sammy1997
Copy link
Contributor

@devanshi7799 Please squash the commits. I can see 5 commits in the PR

@devanshi7799
Copy link
Author

devanshi7799 commented Apr 12, 2020

@sammy i will make the necessary changes and upadate the PR soon :))

@devanshi7799
Copy link
Author

@sammy1997 I have squashed the commits. Can you please review it?

@sammy1997
Copy link
Contributor

sammy1997 commented Apr 15, 2020

I can still see that the text is coming out of the pad. Wrapping the text or auto-resizing would be a better way to solve this. Can you try that @devanshi7799 ?

@devanshi7799
Copy link
Author

@sammy1997 Yes sure! I Will solve it and get back to you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texts not visible properly in Vocab Match Game
4 participants