Simplified code

ankane · Oct 26, 2024 · 850680d · 850680d
1 parent a74eaa9
commit 850680d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/lockbox/model.rb b/lib/lockbox/model.rb
@@ -428,16 +428,14 @@ def reload
               else
                 attribute name, :string
               end
-            else
+            elsif attributes_to_define_after_schema_loads[name.to_s].first.is_a?(Proc)
               # hack for Active Record 6.1+ to set string type after serialize
               # otherwise, type gets set to ActiveModel::Type::Value
               # which always returns false for changed_in_place?
               # earlier versions of Active Record take the previous code path
-              if attributes_to_define_after_schema_loads[name.to_s].first.is_a?(Proc)
-                attribute_type = attributes_to_define_after_schema_loads[name.to_s].first.call(nil)
-                if attribute_type.is_a?(ActiveRecord::Type::Serialized) && attribute_type.subtype.nil?
-                  attribute name, ActiveRecord::Type::Serialized.new(ActiveRecord::Type::String.new, attribute_type.coder)
-                end
+              attribute_type = attributes_to_define_after_schema_loads[name.to_s].first.call(nil)
+              if attribute_type.is_a?(ActiveRecord::Type::Serialized) && attribute_type.subtype.nil?
+                attribute name, ActiveRecord::Type::Serialized.new(ActiveRecord::Type::String.new, attribute_type.coder)
               end
             end