Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an issue causing timezone:false not to be respected #15

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

pelletencate
Copy link
Contributor

Groupdate has this delightful time_zone: false setting that allows you to group by date fields. I like using this in rollup as well, I have a table where I have a date field that the rollup is based on, but my app's TZ is usually somewhere in America. As a result, groupdate casts it to a time in the evening of the day before, and the whole rollup shifts one day backwards.

This PR intends to fix it by ignoring time zones if desired.

@ankane ankane merged commit 3357d83 into ankane:master Feb 10, 2024
4 checks passed
@ankane
Copy link
Owner

ankane commented Feb 10, 2024

Thanks @pelletencate, great find and fix! Will push a new release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants