Skip to content

Commit

Permalink
Pass false to Rust binding for vertical concat of lazy frames (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
martinshjung authored Aug 2, 2023
1 parent e6d3497 commit 23af362
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/polars/functions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,10 @@ def concat(items, rechunk: true, how: "vertical", parallel: true)
raise ArgumentError, "how must be one of {{'vertical', 'diagonal', 'horizontal'}}, got #{how}"
end
elsif first.is_a?(LazyFrame)
# TODO: Implement the rest of the logic in Python:
# https://github.com/pola-rs/polars/blob/rs-0.31.1/py-polars/polars/functions/eager.py#L170-L179
if how == "vertical"
# TODO
return Utils.wrap_ldf(_concat_lf(items, rechunk, parallel))
return Utils.wrap_ldf(_concat_lf(items, rechunk, parallel, false))
else
raise ArgumentError, "Lazy only allows 'vertical' concat strategy."
end
Expand Down

0 comments on commit 23af362

Please sign in to comment.