Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet is 1 #373

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet is 1 #373

wants to merge 7 commits into from

Conversation

ijajmulani
Copy link

SUMMARY

Fixes #372

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible.utils.ipaddr

ADDITIONAL INFORMATION

If non CIDR IP is given to ansible.utils.ipaddr('host/prefix') function is not returning False value.
e.g

 "192.168.0.21" | ansible.utils.ipaddr('host/prefix')

Ideally above code should return False value. Hence corrected the behavior.

---
- name: Validate IP address in CIDR notation
  hosts: localhost
  gather_facts: no
  vars:
    # Replace this with your actual IP address in CIDR notation
    host_ip_cidr: "2620:128:f021:9028::112"  # Can be IPV4

  tasks:
    - name: Check if the IP address in CIDR notation is valid
      assert:
        that:
          - host_ip_cidr | ansible.utils.ipaddr('host/prefix')
        msg: "Invalid IP address in CIDR notation. Enter a valid IP address in CIDR notation. For example, 192.168.0.2/24 or 2001::1/64."

    - name: Output the validation result
      debug:
        msg: "The IP address {{ host_ip_cidr }} is valid in CIDR notation."

if we run above playbook before my change, then playbook passes

# Before my change
ansible-playbook a.yml
------------------------------------------------------------------------------------------------------------------------------
Log Path:                                                             /var/log/ansible/PLAYBOOK/2024-09-10T16-15-20.093922.log
Configuring:                                                                                                             100%

After my change playbook fails as expected.

ansible-playbook a.yml
------------------------------------------------------------------------------------------------------------------------------
Log Path:                                                             /var/log/ansible/PLAYBOOK/2024-09-10T16-16-00.069168.log
Configuring:                                                                                                               0%

Task Name: Check if the IP address in CIDR notation is valid
Error:
 "Invalid IP address in CIDR notation. Enter a valid IP address in CIDR notation. For example, 192.168.0.2/24 or 2001::1/64."

@ijajmulani
Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet …
cf6e761 
…is 1.

If non CIDR IP is given to  ansible.utils.ipaddr('host/prefix') function is not returning False value.
e.g
```
 "192.168.0.21" | ansible.utils.ipaddr('host/prefix')
```
Ideally above code should return False value.  Hence corrected the behaviour.
@ijajmulani
Merge pull request #1 from ijajmulani/ijajmulani-patch-1
04eec0b 
Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet …
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6b4b661fb9cc40bea0eebb6e467d6fcf

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 5m 49s

@ijajmulani
Fixed ansible.utils.ipaddr('host/prefix') function if size of ip's in…
21d0d8a 
… subnet is 1.

Fixed ansible.utils.ipaddr('host/prefix') function if size of ip's in subnet is 1.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/406df7a9b1614dbabf8beb3de176a392

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 5m 49s

@ijajmulani
Update ipaddr _address_prefix_query testcases to test single ip.
b07e5cc 
Update ipaddr _address_prefix_query testcases to test single ip.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/04e4003cf71c4eb48644b9f6721e9d5a

✔️ ansible-galaxy-importer SUCCESS in 3m 33s
✔️ build-ansible-collection SUCCESS in 5m 47s

@ijajmulani
Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet …
8f161ba 
…is 1.

Fixed ansible.utils.ipaddr('host/prefix') function if size of subnet is 1.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/648d2f6e2f8f4ab4b4b9ee7d86d39c0a

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 5m 46s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3c85b929232e4356ba8c93b1a54e064d

✔️ ansible-galaxy-importer SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 5m 22s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16

@AAYUSH2091 AAYUSH2091 Awaiting requested review from AAYUSH2091

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible.utils.ipaddr('host/prefix') should not parse non CIDR IP.
2 participants
@ijajmulani @Ruchip16