Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssh_* modules: check return code on ssh(-keygen) invocations; fail if comment cannot be updated #646

Merged
merged 7 commits into from
Aug 12, 2023
Merged

openssh_* modules: check return code on ssh(-keygen) invocations; fail if comment cannot be updated #646

merged 7 commits into from
Aug 12, 2023

Commits on Aug 11, 2023

  1. Check return code on ssh(-keygen) invocations.

    @felixfontein
    felixfontein committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9c2fbc8 View commit details
    Browse the repository at this point in the history

  2. openssh_cert: only check for errors if certificate should be present … 

    …and module is not in check mode.
    @felixfontein
    felixfontein committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    244e7a6 View commit details
    Browse the repository at this point in the history

  3. Handle rc check for _get_private_key().

    @felixfontein
    felixfontein committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4eaf555 View commit details
    Browse the repository at this point in the history

  4. Add changelog fragment.

    @felixfontein
    felixfontein committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    379ddaf View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Only pass -o for comment updating when necessary.

    @felixfontein
    felixfontein committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    57844d2 View commit details
    Browse the repository at this point in the history

  2. Now fails if comment cannot be updated. 

    This was silently ignored in the past.
    @felixfontein
    felixfontein committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    1529fda View commit details
    Browse the repository at this point in the history

  3. Avoid failing operation.

    @felixfontein
    felixfontein committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    c183648 View commit details
    Browse the repository at this point in the history