-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inventory filter capability #698
Conversation
76b2b7c
to
b323971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool! While it might be weird to take a dependency on c.docker
for this alone, the plugin_util isn't named with an underscore or a notice about it being private. Would it be considered fair game to use it in that case? I don't have any plans to right now, just mentioning in case you didn't want to have to keep breaking changes to major versions or whatever.
IMO using this plugin_utils / docs_fragment from community.docker in other collections would be fine. If you plan to do so (especially with public collections) please make sure you test against the current |
d435bf1
to
773c1f3
Compare
|
This is required to make CI in #698 pass.
baf8efd
to
09edf7e
Compare
The dependency is now part of Ansible, so it's time to continue this :) |
recheck |
1 similar comment
recheck |
Too bad if third-party-check fails... |
f429017
into
ansible-collections:main
9.2.0 Major Changes ------------- community.docker ~~~~~~~~~~~~~~~~ - The ``community.docker`` collection now depends on the ``community.library_inventory_filtering_v1`` collection. This utility collection provides host filtering functionality for inventory plugins. If you use the Ansible community package, both collections are included and you do not have to do anything special. If you install the collection with ``ansible-galaxy collection install``, it will be installed automatically. If you install the collection by copying the files of the collection to a place where ansible-core can find it, for example by cloning the git repository, you need to make sure that you also have to install the dependency if you are using the inventory plugins (ansible-collections/community.docker#698). community.hashi_vault ~~~~~~~~~~~~~~~~~~~~~ - requirements - the ``requests`` package which is required by ``hvac`` now has a more restrictive range for this collection in certain use cases due to breaking security changes in ``ansible-core`` that were backported (ansible-collections/community.hashi_vault#416). dellemc.openmanage ~~~~~~~~~~~~~~~~~~ - All OME modules are enhanced to support the environment variables `OME_USERNAME` and `OME_PASSWORD` as fallback for credentials. - All iDRAC and Redfish modules are enhanced to support the environment variables `IDRAC_USERNAME` and `IDRAC_PASSWORD` as fallback for credentials. - idrac_certificates - The module is enhanced to support the import and export of `CUSTOMCERTIFICATE`. - idrac_gather_facts - This role is enhanced to support secure boot. - idrac_license - The module is introduced to configure iDRAC licenses. infoblox.nios_modules ~~~~~~~~~~~~~~~~~~~~~ - Upgrade Ansible version support from 2.13 to 2.16. - Upgrade Python version support from 3.8 to 3.10.
SUMMARY
Adds a
filter
option to all inventory plugins which allows to exclude/include hosts based on Jinja2 expressions.This is a generic mechanism which can also be used in other inventory plugins (outside of this collection), similar to the
Constructable
mixin from ansible-core.Fixes #610.
ISSUE TYPE
COMPONENT NAME
inventory plugins