Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_compose_v2: move some code to module_utils #747

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Makes it easier to add other docker_compose_v2 modules, such as docker_compose_v2_pull.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_compose_v2

@felixfontein
Copy link
Collaborator Author

felixfontein commented Jan 7, 2024

@lel-amri FYI, I've added some (currently "auto-generated") unit tests for events parsing based on stderr obtained from real docker compose runs in CI.

Extracing the logs also got the following stats on Docker compose plugin versions used in CI:

  • 2.1.1, 2.12.2, 2.14.2, and 2.17.3 are available, but not used (since too old)
  • 2.18.1 appears in one run
  • 2.21.0 apperas in 11 runs
  • 2.23.3 appears in one run

Right now the auto-generated tasks have a lot of duplication, I'll eventually improve the generation script to remove that as much as possible.

@felixfontein felixfontein merged commit cb4dd2f into ansible-collections:main Jan 7, 2024
120 of 121 checks passed
@felixfontein felixfontein deleted the compose branch January 7, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant