Incorrect handling of missing 'rules' parameter in appliance_networking_firewall_inbound module in vmware_rest

[prabinovRedhat]

Summary

About the appliance_networking_firewall_inbound module in vmware_rest.
I noticed that when the rules parameter is missing, the module returns the message:
"missing required arguments: rules"
But the failed flag is still false.
Here’s what I got:

mandatory_rule_check:
  changed: false
  failed: false
  msg: "missing required arguments: rules"

It feels like the module should set failed=True when a required parameter is missing.

Issue Type

Feature Idea

Component Name

appliance_networking_firewall_inbound

Additional Information

No response

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[mikemorency]

The error is coming from the rest api and the module is just passing it to the user. The module is not actually checking the response code and handling errors.

i think we should approach this similar to #385
Short term, document a work around
Long term, move to vmware.vmware