CI - linters and changelog github actions workflow #410
Conversation
|
recheck |
|
This change depends on a change that failed to merge. Change ansible/ansible-zuul-jobs#1789 is needed. |
|
There already is a test for a changelog: #406 / #433 For the linter test, I don't understand why you use Actually, I think it would be best to have linting in ansible-collections/collection_template and we could just copy it it to this collection. Maybe you should create a PR there to implement a default linting CI workflow ;-) |
@mariolenz this PR needs some updates. |
…inter from ansible-network/github_actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 35.67% 35.67%
=======================================
Files 143 143
Lines 11305 11305
Branches 2291 2291
=======================================
Hits 4033 4033
Misses 7197 7197
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Build succeeded. ✔️ build-ansible-collection SUCCESS in 11m 02s |
There was a problem hiding this comment.
I'm no GHA expert but as far as I can see this LGTM.
@alinabuzachis What do you think?
I've removed this. I think it makes more sense if removing those tests from Zuul should depend on implementing them here in the collection instead of the other way around ;-) |
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/f816da8c9beb48d2aad2edd775f0e067 ✔️ build-ansible-collection SUCCESS in 10m 38s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ build-ansible-collection SUCCESS in 17m 22s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
|
Cool, we now also have a GHA linting workflow. Thanks @abikouo! |
vmware_rest: Remove 2.13 / 2.14 sanity tests Depends-On: #1830 Moving 2.13 / 2.14 sanity tests to GHA. cc @alinabuzachis edit: Also remove linting: ansible-collections/vmware.vmware_rest#410 Reviewed-by: Alina Buzachis
CI migration from zuul to GHA