Fix GHA sanity tests

.github/workflows/ansible-test.yml

@@ -78,6 +78,7 @@ jobs:
           - stable-2.13
           - stable-2.14
           - stable-2.15
+        # - stable-2.16
         # - devel
         # - milestone
     # Ansible-test on various stable branches does not yet work well with cgroups v2.
@@ -105,10 +106,12 @@ jobs:
           # test-deps: >-
           #   ansible.netcommon
           #   ansible.utils
+          test-deps: >-
+            cloud.common
           # OPTIONAL If set to true, will test only against changed files,
           # which should improve CI performance. See limitations on
           # https://github.com/ansible-community/ansible-test-gh-action#pull-request-change-detection
-          pull-request-change-detection: true
+          pull-request-change-detection: false
 
   check:  # This job does nothing and is only used for the branch protection
           # or multi-stage CI jobs, like making sure that all tests pass before

changelogs/fragments/fix_gha_sanity_tests.yaml

@@ -0,0 +1,3 @@
+---
+trivial:
+- "Fix GHA sanity tests."

plugins/modules/appliance_access_consolecli.py

@@ -102,8 +102,6 @@
     "set": {"query": {}, "body": {"enabled": "enabled"}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -118,12 +116,9 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
     exists,
     gen_args,
-    get_device_info,
     get_subdevice_type,
-    list_devices,
     open_session,
     prepare_payload,
     update_changed_flag,

plugins/modules/appliance_access_consolecli_info.py

@@ -90,8 +90,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -106,14 +104,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_access_dcui.py

@@ -102,8 +102,6 @@
     "set": {"query": {}, "body": {"enabled": "enabled"}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -118,12 +116,9 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
     exists,
     gen_args,
-    get_device_info,
     get_subdevice_type,
-    list_devices,
     open_session,
     prepare_payload,
     update_changed_flag,

plugins/modules/appliance_access_dcui_info.py

@@ -90,8 +90,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -106,14 +104,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_access_shell.py

@@ -123,8 +123,6 @@
     }
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -139,12 +137,9 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
     exists,
     gen_args,
-    get_device_info,
     get_subdevice_type,
-    list_devices,
     open_session,
     prepare_payload,
     update_changed_flag,

plugins/modules/appliance_access_shell_info.py

@@ -95,8 +95,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -111,14 +109,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_access_ssh.py

@@ -103,8 +103,6 @@
     "set": {"query": {}, "body": {"enabled": "enabled"}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -119,12 +117,9 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
     exists,
     gen_args,
-    get_device_info,
     get_subdevice_type,
-    list_devices,
     open_session,
     prepare_payload,
     update_changed_flag,

plugins/modules/appliance_access_ssh_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_applmgmt_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_database_info.py

@@ -85,8 +85,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -101,14 +99,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_databasestorage_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_load_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_mem_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_softwarepackages_info.py

@@ -96,8 +96,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -112,14 +110,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )

plugins/modules/appliance_health_storage_info.py

@@ -91,8 +91,6 @@
     "get": {"query": {}, "body": {}, "path": {}}
 }  # pylint: disable=line-too-long
 
-import json
-import socket
 from ansible.module_utils.basic import env_fallback
 
 try:
@@ -107,14 +105,8 @@
 except ImportError:
     from ansible.module_utils.basic import AnsibleModule
 from ansible_collections.vmware.vmware_rest.plugins.module_utils.vmware_rest import (
-    build_full_device_list,
-    exists,
     gen_args,
-    get_device_info,
-    get_subdevice_type,
-    list_devices,
     open_session,
-    prepare_payload,
     update_changed_flag,
     session_timeout,
 )