Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported ansible-version as >=2.14 #446

Merged

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY

Dropped support for ansible-version <=2.13 . Updated cloud.common version in galaxy.yml

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b93d0cc) 35.67% compared to head (6f3abd2) 35.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   35.67%   35.67%           
=======================================
  Files         143      143           
  Lines       11305    11305           
  Branches     2291     2291           
=======================================
  Hits         4033     4033           
  Misses       7272     7272           
Flag Coverage Δ
sanity 35.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

galaxy.yml Outdated Show resolved Hide resolved
Copy link
Contributor

galaxy.yml Show resolved Hide resolved
@jillr jillr changed the title Update supported ansible-version as >=2.14 [WIP] Update supported ansible-version as >=2.14 Nov 15, 2023
@mariolenz
Copy link
Collaborator

ansible-galaxy-importer failed with:

ERROR! Failed to resolve the requested dependencies map. Got the candidate cloud.common:2.1.5-dev8 (dependency of vmware.vmware_rest:3.0.0) which didn't satisfy all of the following requirements:
* cloud.common:2.1.5-dev8
* cloud.common:>=3.0.0,<4.0.0
Hint: Pre-releases hosted on Galaxy or Automation Hub are not installed by default unless a specific version is requested. To enable pre-releases globally, use --pre.
Starting galaxy collection install process
Process install dependency map

Do we have some kind of circular dependency here?

@alinabuzachis
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

@alinabuzachis recheck doesn't restart the GHA workflows. Let's close and re-open in a few minutes.

@mariolenz mariolenz closed this Nov 17, 2023
@mariolenz mariolenz reopened this Nov 17, 2023
@alinabuzachis
Copy link
Collaborator

@alinabuzachis recheck doesn't restart the GHA workflows. Let's close and re-open in a few minutes.

right, thanks!

@mariolenz mariolenz mentioned this pull request Nov 17, 2023
Copy link
Contributor

@mariolenz
Copy link
Collaborator

I'm missing the integration tests in ansible/check... I've created #447 to run them with cloud.common 3.0.0.

@mariolenz
Copy link
Collaborator

Looks like the integration tests succeeded in #447 with cloud.common 3.0.0. What now? Remove the WIP and merge?

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GomathiselviS GomathiselviS changed the title [WIP] Update supported ansible-version as >=2.14 Update supported ansible-version as >=2.14 Nov 17, 2023
@GomathiselviS
Copy link
Contributor Author

Looks like the integration tests succeeded in #447 with cloud.common 3.0.0. What now? Remove the WIP and merge?

I'll merge the PR once I receive a couple more approvals. After that, we'll prepare the collection for release.

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e03c85816ea74268ba49b0b1e3be5c0a

✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 11m 04s
✔️ ansible-galaxy-importer SUCCESS in 4m 51s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 396da7b into ansible-collections:main Nov 17, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants