Prep 3.0.0 using vSphere API version 7.0.3 #451
Conversation
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 35s |
|
@mariolenz @jillr Integration tests seem passing in the CI with the new new API version. I used this one #449 |
|
Cool! There are a lot of linter errors, though. I think we can fix those I'll create a PR for that and then maybe we can try again. |
|
@alinabuzachis Did the three new mappings I've suggested fix generating the modules? If yes, I would add them to my PR. |
|
@alinabuzachis @jillr ansible-community/ansible.content_builder#74 Once this one and ansible-community/ansible.content_builder#73 are merged, I think we should give it another try 😃 |
Yes, they fixed. Can you please add them here ansible-community/ansible.content_builder#73? |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
prep_3_0_0_api_7_0_3
branch
from
18777bb to
980d895
Compare
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 16m 05s |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
changed the title
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 42s |
There was a problem hiding this comment.
@alinabuzachis There are still a lot of failing CI jobs, and I think we should fix them before merging. I'm sure ansible-community/ansible.content_builder#73 and ansible-community/ansible.content_builder#74 would, but we need someone to merge them. I've tested in #452 and this looked OK to me. Of course, you can patch my changes into your local content_builder but having them upstream would be better.
One other thing: I've removed all module documentation from the community.vmware repository. It just felt like a waste of resources to generate them and drag them around. The stuff is available in the Ansible community documentation, anyway... and your module documentation is, too. Maybe you should consider this also. Just an idea ;-)
Since this doesn't concern the published collection, I don't think this would need a new major release and you could do it anytime. But preparing one, anyway, seems like a good moment to do it. That is, if you want to do it... as I've said: Just an idea.
alinabuzachis
force-pushed
the
prep_3_0_0_api_7_0_3
branch
from
2909b90 to
07a3d8a
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
prep_3_0_0_api_7_0_3
branch
from
07a3d8a to
32e08ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 35.67% 34.15% -1.52%
==========================================
Files 143 143
Lines 11305 11055 -250
Branches 2291 2294 +3
==========================================
- Hits 4033 3776 -257
- Misses 7272 7279 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixed linters and sanity errors! I tested too and those patches look good to me! Thanks! We have the same way of handing docs in other collections too (see amazon.aws https://docs.ansible.com/ansible/latest/collections/amazon/aws/index.html). I'll try to add the Github workflow in another PR and eventually merged it after the 3.0.0 release. We can always do minor releases. |
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 51s |
There was a problem hiding this comment.
LGTM
content_builder has created new sanity ignores for 2.9 to 2.13. We don't need them anymore, but I don't think we have to remove them now. We can do this later, no problem.
Maybe someone else should also have a look at this. Nearly 300 changed files is quite a lot and it's easy to overlook something.
|
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 56s |
softwarefactory-project-zuul
bot
merged commit be7e57d
into
ansible-collections:main
|
🥳 |
SUMMARY
Prep 3.0.0 using vSphere API version 7.0.3
Release date is Monday November 27.
ISSUE TYPE
- New Module Pull RequestCOMPONENT NAME
several