Release 3.0.1 #489
Release 3.0.1 #489
Conversation
Signed-off-by: Ondra Machacek <omachace@redhat.com>
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 18s |
Signed-off-by: Ondra Machacek <omachace@redhat.com>
The content_build specify the default value for bus to 0, but it don't set it for the documentation, so this commit update the doc manually. Signed-off-by: Ondra Machacek <omachace@redhat.com>
machacekondra
force-pushed
the
release_3_0_1
branch
from
51f03cf to
5cabd7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable-3 #489 +/- ##
============================================
+ Coverage 34.18% 34.20% +0.02%
============================================
Files 143 143
Lines 11040 11032 -8
Branches 2291 2279 -12
============================================
Hits 3774 3774
+ Misses 7266 7258 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 44s |
machacekondra
force-pushed
the
release_3_0_1
branch
from
5cabd7d to
2c52fa5
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
machacekondra
force-pushed
the
release_3_0_1
branch
from
2c52fa5 to
cd18a48
Compare
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 33s |
|
Everything appears good. However, I would prefer this PR to exclusively contain the release-related modifications. Would it be possible to split this PR, moving the module and documentation changes to a separate one? Once the other PR is merged, we can rebase this release PR. @mariolenz @alinabuzachis Your thoughts? |
Any changes to the modules are the reflection of the content_builder's changes. As far as I know, documentation regeneration is part of the prep release PR as a consequence of plugins regeneration. We used to include all these in a prep release PR ( for example: #451) |
|
The relevant changes are in specific commit, but in single PR, so all relevant changes will be nicely seen in git history. But if needed it may be split into two PRs. But I think it's not an issue here. The issue here is that we don't which content_builder commit was used to do this release I think that would simplify the review a lot, because we would have PRs like bump to content_builder 1.0.x. So I think this is a good time to talk about versioning the content_builder, to make the releases more predictable. |
My request to split this PR is aimed at enhancing the clarity regarding the intent and scope of these modifications for the stakeholders. While this request is optional, I would prefer to adopt it for future changes. Additionally, including a changelog that outlines how the alterations in content_builder have influenced module and documentation generation would facilitate future reference in the git history. Considering versioning for content_builder is also a valuable aspect that we can address as we proceed with the release process with the current changes. |
Signed-off-by: Ondra Machacek <omachace@redhat.com>
Signed-off-by: Ondra Machacek <omachace@redhat.com>
Signed-off-by: Ondra Machacek <omachace@redhat.com>
machacekondra
force-pushed
the
release_3_0_1
branch
from
cd18a48 to
e89927e
Compare
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 28s |
|
Since there are three approvals: Is there any reason to not merge and release this? |
|
/lgtm |
|
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 40s |
softwarefactory-project-zuul
bot
merged commit 8e3e47d
into
ansible-collections:stable-3
Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz <m@riolenz.de> Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis
Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz <m@riolenz.de> Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis
Cherry pick all the changes from Release 3.0.1 (#489) Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz m@riolenz.de Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis
Cherry pick all the changes from Release 3.0.1 (ansible-collections#489) Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz m@riolenz.de Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis (cherry picked from commit de4b81c)
Cherry pick all the changes from Release 3.0.1 (ansible-collections#489) Release 3.0.1 Release 3.0.1 Reviewed-by: Mario Lenz m@riolenz.de Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis (cherry picked from commit de4b81c)
Release 3.0.1