Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate content_library_item_info due to module generation issues #551

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Fixes issue
#540

Deprecate module content_library_item_info in favor of vmware.vmware.content_library_item_info. The module in this collection was not generated correctly, leading to it failing in some use cases. We cannot easily fix this since the issue is in the openapi spec provided by vmware.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

content_library_item_info

Copy link
Contributor

@billy-stellar
Copy link

@mikemorency does this mean vmware.vmware will soon have a .content_library_item_info module? I don't see that documented today, nor in the source code.

@mikemorency
Copy link
Collaborator Author

Hi @billy-stellar ,

Yes, we will be adding a content_library_item_info module with the next minor release. The PR to add the module is open in the vmware.vmware repo.
Both vmware.vmware and vmware.vmware_rest have minor releases planned in the next ~2 weeks

@mariolenz
Copy link
Collaborator

@mikemorency Some of the tests fail. I think I had a similar problem in community.vmware and solved it like this:

https://github.com/ansible-collections/community.vmware/blob/394a5a6bc05288af8054e8d1e20cba94a2957b7d/.github/workflows/extra-docs-linting.yml#L34-L37

I'm not sure if you would also have to install vmware.vmware somewhere explicitly, but I think you should wait until the module really is part of vmware.vmware to make the CI happy.

Both vmware.vmware and vmware.vmware_rest have minor releases planned in the next ~2 weeks

There will be new releases of the Ansible Community Package December 3rd, and the next one will be end of January. It would be great if you could do those releases in time so we can include them! Of course, this will only work if we're talking about minor releases here ;-)

BTW those will be the last 9.x and 10.x releases. From then on, it's ansible 11 or nothing.

@mikemorency mikemorency force-pushed the feature/deprecate-content-library-item-info branch from 36398d2 to 04b106e Compare November 25, 2024 16:19
@mikemorency mikemorency force-pushed the feature/deprecate-content-library-item-info branch from 33561a6 to f71dcfd Compare November 25, 2024 16:40
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (7cc48d2) to head (afcf3c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         145      145           
  Lines       11395    11395           
  Branches     2261     2261           
=======================================
  Hits         4222     4222           
  Misses       7173     7173           
Flag Coverage Δ
sanity 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mikemorency!

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b03722018d7445fb90f941b7cd48db83

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 41s
✔️ build-ansible-collection SUCCESS in 7m 22s
✔️ ansible-galaxy-importer SUCCESS in 6m 37s

Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz
Copy link
Collaborator

mariolenz commented Nov 25, 2024

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mikemorency I think mergeitdoesn't work if there are any changes to the workflows. Let's just merge it the hard way and test afterwards.

@mariolenz mariolenz merged commit 4090b9f into ansible-collections:main Nov 25, 2024
15 of 16 checks passed
@mariolenz mariolenz mentioned this pull request Nov 25, 2024
@mariolenz
Copy link
Collaborator

It looks like the integration tests still succeed: #553

So let's say it's OK :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants