-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate content_library_item_info due to module generation issues #551
deprecate content_library_item_info due to module generation issues #551
Conversation
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 19s |
@mikemorency does this mean vmware.vmware will soon have a .content_library_item_info module? I don't see that documented today, nor in the source code. |
Hi @billy-stellar , Yes, we will be adding a content_library_item_info module with the next minor release. The PR to add the module is open in the vmware.vmware repo. |
@mikemorency Some of the tests fail. I think I had a similar problem in I'm not sure if you would also have to install
There will be new releases of the Ansible Community Package December 3rd, and the next one will be end of January. It would be great if you could do those releases in time so we can include them! Of course, this will only work if we're talking about minor releases here ;-) BTW those will be the last 9.x and 10.x releases. From then on, it's ansible 11 or nothing. |
36398d2
to
04b106e
Compare
33561a6
to
f71dcfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 37.05% 37.05%
=======================================
Files 145 145
Lines 11395 11395
Branches 2261 2261
=======================================
Hits 4222 4222
Misses 7173 7173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 09s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @mikemorency!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 41s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
@mikemorency I think |
It looks like the integration tests still succeed: #553 So let's say it's OK :-) |
SUMMARY
Fixes issue
#540
Deprecate module content_library_item_info in favor of vmware.vmware.content_library_item_info. The module in this collection was not generated correctly, leading to it failing in some use cases. We cannot easily fix this since the issue is in the openapi spec provided by vmware.
ISSUE TYPE
COMPONENT NAME
content_library_item_info