Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the built directory does not exist, antsibull-build rebuild-single will write a tarball file named "built" #250

Open
abadger opened this issue Feb 2, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@abadger
Copy link
Contributor

abadger commented Feb 2, 2021

[pts/5@peru /srv/ansible/vanilla-antsibull]$ rm -rf built                          *[main]  (13:17:53)
[pts/5@peru /srv/ansible/vanilla-antsibull]$ poetry run antsibull-build rebuild-single 3.0.0b1 --data-dir /srv/ansible/ansible-build-data/3 --build-file ansible-3.build --deps-file ansible-3.0.0b1.deps --sdist-dir built --debian
[pts/5@peru /srv/ansible/vanilla-antsibull]$ ls -al built                          *[main]  (13:28:30)
-rw-r--r--. 1 badger badger 30739347 Feb  2 13:23 built
[pts/5@peru /srv/ansible/vanilla-antsibull]$ file built                            *[main]  (13:28:32)
built: gzip compressed data, was "ansible-3.0.0b1.tar", last modified: Tue Feb  2 21:23:08 2021, max compression, original size modulo 2^32 255057920

Reading the code, I think the intention was that it should write ansible-3.0.0b1.tar.gz to the current directory instead.

@abadger abadger added the bug Something isn't working label Feb 2, 2021
@felixfontein
Copy link
Collaborator

But there is:

    if args.command in ('single', 'multiple'):
        if not os.path.isdir(args.sdist_dir):
            raise InvalidArgumentError(f'{args.sdist_dir} must be an existing directory')

I wonder if that does not get called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants