Stop calling distribution packages sdists?

[webknjaz]

I noticed that antsibull-build rebuild-single accepts --sdist-dir which is technically a lie. It calls python -m build internally that produces both an sdist and a wheel.

The helper function is kinda called correctly: https://github.com/ansible-community/antsibull/blob/f6fda44642e8c1d7f346cde2715dc62a824681ae/src/antsibull/build_ansible_commands.py#L316 — make_dist_with_wheels(). "Kinda" because wheels are dists, it's like daying "dist with dists".
And it's called with an "sdist dir" at https://github.com/ansible-community/antsibull/blob/f6fda44642e8c1d7f346cde2715dc62a824681ae/src/antsibull/build_ansible_commands.py#L742C9-L742C71.

This confusion leaked into the CLI/UX and external descriptions, including GHA workflows with steps like "Upload Ansible sdist to PyPI” being inspired by the misconception that it doesn't upload wheels.

Hence $sbj.

[felixfontein]

Yes, it makes sense to rename it.

[gotmax23]

Yeah, this is all leftover from the time when we had that setup.py mess to warn users updating from ansible 2.9 and thus couldn't ship wheels.

I don't feel strongly about the function name, but feel free to submit a PR. The code is private (i.e. we don't promise a stable API), so changing it won't pose compatibility problems.

As for

https://github.com/ansible-community/antsibull/blob/f6fda44642e8c1d7f346cde2715dc62a824681ae/src/antsibull/cli/antsibull_build.py#L392-L396

I agree that's a problem. We should at least fix the help message. I would also add a --dist-dir argument for this and potentially deprecate --sdist-dir. We'll probably have to make a similar change to the release playbook.