changes to align to updated website pillars #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccann
reviewed
Mar 15, 2024
conf.py
Outdated
| @@ -150,31 +150,21 @@ | |||
| # (Bootstrap 4: right-side of navbar, Bootblog 4: right side of title) | |||
| NAVIGATION_ALT_LINKS = { | |||
| DEFAULT_LANG: ( | |||
| ("https://docs.ansible.com/", "Documentation", ""), | |||
There was a problem hiding this comment.
This now a problematic link as this site is no longer a community site. Either change to Community documentation or remove it entirely.
This is a problem in other places as well where we point to docs.ansible.com but not to AAP docs on redhat.com. Not sure how you want to address those problems.
There was a problem hiding this comment.
Good point and I will see how they wish to address this concern. My guess is the label will change.
There was a problem hiding this comment.
@samccann The concern reported as been resolved with a dropdown menu for documentation.
|
Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.