-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmware_rest: Remove 2.13 / 2.14 sanity tests #1826
vmware_rest: Remove 2.13 / 2.14 sanity tests #1826
Conversation
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 27m 35s |
Thanks for reviewing @alinabuzachis! Now that ansible-collections/vmware.vmware_rest#431 is merged, I think this PR is ready to be merged, too 😃 |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/6378d043907040069be037c2ac4d0932 ✔️ ansible-tox-linters SUCCESS in 12m 06s |
@alinabuzachis I don't really understand the gate failure. Is this some problem in the CI or in the collection? |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/d231d4f4a81d4f5694fdf3022d9f2cd5 ✔️ ansible-tox-linters SUCCESS in 17m 38s |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/3a9d88afdae849e7a12268306652c48e ✔️ ansible-tox-linters SUCCESS in 12m 03s |
Interesting. I've created #1828 with the exactly same changes and now |
Build failed. ✔️ ansible-tox-linters SUCCESS in 18m 38s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 12m 01s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 12m 26s |
Interestingly, in the first run (the one that succeeded) I see:
In the runs that fail I see:
A new version (2.7.1 instead of 2.6.0) and no mention of pulling in fixtures as a dependency for testtools. |
Yep, I think that's it. It looks like fixtures is needed for the tests, but testtools doesn't pull it in automatically since 2.7.0. |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 20m 57s |
@alinabuzachis I think the CI failure can be fixed with #1830 😃 |
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 18m 03s |
Fix ansible-tox-py38 / 39 / 310 For more information see #1826 (comment) edit: testing-cabal/testtools#367 Reviewed-by: Alina Buzachis
Thanks for reviewing @alinabuzachis! |
Depends-On: #1830
Moving 2.13 / 2.14 sanity tests to GHA.
cc @alinabuzachis
edit:
Also remove linting: ansible-collections/vmware.vmware_rest#410