Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_rest: Remove 2.13 / 2.14 sanity tests #1826

Merged

Conversation

mariolenz
Copy link
Contributor

@mariolenz mariolenz commented Nov 1, 2023

Depends-On: #1830

Moving 2.13 / 2.14 sanity tests to GHA.

cc @alinabuzachis

edit:
Also remove linting: ansible-collections/vmware.vmware_rest#410

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/87cd48c20fd04c9d9f6f10c40b9e2cb2

✔️ ansible-tox-linters SUCCESS in 27m 35s
✔️ ansible-tox-py38 SUCCESS in 18m 03s
✔️ ansible-tox-py39 SUCCESS in 21m 08s
✔️ ansible-tox-py310 SUCCESS in 17m 00s

@mariolenz
Copy link
Contributor Author

Thanks for reviewing @alinabuzachis!

Now that ansible-collections/vmware.vmware_rest#431 is merged, I think this PR is ready to be merged, too 😃

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFActory) label Nov 2, 2023
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/6378d043907040069be037c2ac4d0932

✔️ ansible-tox-linters SUCCESS in 12m 06s
ansible-tox-py38 FAILURE in 12m 48s
ansible-tox-py39 FAILURE in 12m 33s

@mariolenz
Copy link
Contributor Author

@alinabuzachis I don't really understand the gate failure. Is this some problem in the CI or in the collection?

@mariolenz
Copy link
Contributor Author

regate

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/d231d4f4a81d4f5694fdf3022d9f2cd5

✔️ ansible-tox-linters SUCCESS in 17m 38s
ansible-tox-py38 FAILURE in 20m 53s
ansible-tox-py39 FAILURE in 17m 11s

@mariolenz
Copy link
Contributor Author

regate

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/3a9d88afdae849e7a12268306652c48e

✔️ ansible-tox-linters SUCCESS in 12m 03s
ansible-tox-py38 FAILURE in 12m 25s
ansible-tox-py39 FAILURE in 12m 36s

@mariolenz
Copy link
Contributor Author

Interesting. I've created #1828 with the exactly same changes and now ansible/check fails there, too. Have there been any changes to Zuul?

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f5d036b2d5d044bb97635b2d77b0e8e3

✔️ ansible-tox-linters SUCCESS in 18m 38s
ansible-tox-py38 FAILURE in 13m 06s
ansible-tox-py39 FAILURE in 13m 04s
ansible-tox-py310 FAILURE in 13m 03s

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/45fb49e33b944c9795ebb9ac9dafee4f

✔️ ansible-tox-linters SUCCESS in 12m 01s
ansible-tox-py38 FAILURE in 12m 33s
ansible-tox-py39 FAILURE in 12m 32s
ansible-tox-py310 FAILURE in 12m 33s

@mariolenz mariolenz closed this Nov 7, 2023
@mariolenz mariolenz reopened this Nov 7, 2023
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4f9a44258c8e41e086e4835e29363e4e

✔️ ansible-tox-linters SUCCESS in 12m 26s
ansible-tox-py38 FAILURE in 12m 49s
ansible-tox-py39 FAILURE in 12m 52s
ansible-tox-py310 FAILURE in 12m 46s

@mariolenz
Copy link
Contributor Author

mariolenz commented Nov 7, 2023

ansible-tox-py38 fails with:

_ ERROR collecting roles/write-inventory-fork/library/test_write_inventory.py __
ImportError while importing test module '/workspace/src/github.com/ansible/ansible-zuul-jobs/roles/write-inventory-fork/library/test_write_inventory.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
roles/write-inventory-fork/library/test_write_inventory.py:19: in <module>
    import fixtures
E   ModuleNotFoundError: No module named 'fixtures'

Interestingly, in the first run (the one that succeeded) I see:

Collecting testtools
  Downloading testtools-2.6.0-py3-none-any.whl (182 kB)
Collecting fixtures>=2.0 (from testtools)
  Downloading fixtures-4.1.0-py3-none-any.whl (64 kB)

In the runs that fail I see:

Collecting testtools
  Downloading testtools-2.7.1-py3-none-any.whl (179 kB)

A new version (2.7.1 instead of 2.6.0) and no mention of pulling in fixtures as a dependency for testtools.

@mariolenz
Copy link
Contributor Author

mariolenz commented Nov 7, 2023

Yep, I think that's it. It looks like fixtures is needed for the tests, but testtools doesn't pull it in automatically since 2.7.0.

edit: testing-cabal/testtools#367

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fd9a1f0740cf4348b292099384bca042

✔️ ansible-tox-linters SUCCESS in 20m 57s
✔️ ansible-tox-py38 SUCCESS in 20m 22s
✔️ ansible-tox-py39 SUCCESS in 21m 12s
✔️ ansible-tox-py310 SUCCESS in 18m 32s

@mariolenz
Copy link
Contributor Author

@alinabuzachis I think the CI failure can be fixed with #1830 😃

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/164e9b6ca1174d70a338a564ac095434

✔️ ansible-tox-linters SUCCESS in 18m 03s
✔️ ansible-tox-py38 SUCCESS in 12m 59s
✔️ ansible-tox-py39 SUCCESS in 18m 19s

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 8, 2023
Fix ansible-tox-py38 / 39 / 310

For more information see #1826 (comment)
edit: testing-cabal/testtools#367

Reviewed-by: Alina Buzachis
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d9060ba into ansible:master Nov 8, 2023
@mariolenz mariolenz deleted the 20231101-vmware_rest branch November 8, 2023 09:31
@mariolenz
Copy link
Contributor Author

Thanks for reviewing @alinabuzachis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFActory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants