Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ANSIBLE_COLLECTION_PATH #139

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Switch to ANSIBLE_COLLECTION_PATH #139

merged 1 commit into from
Aug 1, 2023

Conversation

cidrblock
Copy link
Contributor

Related: ansible/tox-ansible#196

devel has deprecated the plural:

[DEPRECATION WARNING]: ANSIBLE_COLLECTIONS_PATHS option, does not fit var 
naming standard, use the singular form ANSIBLE_COLLECTIONS_PATH instead. This 
feature will be removed from ansible-core in version 2.19. Deprecation warnings
 can be disabled by setting deprecation_warnings=False in ansible.cfg.

Since the tox-ansible plugin is inject the singular, we need the same ehre to be picked up and injected.

Otherwise, the 2 are incompatible and result in these errors.

https://github.com/ansible-collections/ansible.scm/actions/runs/5727484046/job/15520195428?pr=224

@cidrblock cidrblock requested a review from a team as a code owner August 1, 2023 13:58
@cidrblock cidrblock requested review from ssbarnea, priyamsahoo and shatakshiiii and removed request for a team August 1, 2023 13:58
@cidrblock cidrblock added the bug label Aug 1, 2023
@cidrblock
Copy link
Contributor Author

self approving since this is blocking PR in other repos w/o a release

@cidrblock cidrblock merged commit f765152 into ansible:main Aug 1, 2023
12 checks passed
@Ruchip16 Ruchip16 self-requested a review August 1, 2023 14:09
@cidrblock cidrblock mentioned this pull request Aug 1, 2023
Merged
Ruchip16 pushed a commit to Ruchip16/pytest-ansible that referenced this pull request Aug 2, 2023
@cidrblock @Ruchip16
Switch to ANSIBLE_COLLECTION_PATH (ansible#139)
e085bc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible-community/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cidrblock