Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command error checking in 2 places #1199

Merged

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.21%. Comparing base (b89bdac) to head (cfbff11).
Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/command.go 0.00% 8 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1199      +/-   ##
==========================================
+ Coverage   43.95%   44.21%   +0.26%     
==========================================
  Files          33       36       +3     
  Lines        8129     8714     +585     
==========================================
+ Hits         3573     3853     +280     
- Misses       4286     4588     +302     
- Partials      270      273       +3     
Files with missing lines Coverage Δ
pkg/workceptor/command.go 45.68% <0.00%> (-0.67%) ⬇️

... and 6 files with indirect coverage changes

Components Coverage Δ
Go 43.85% <0.00%> (-0.11%) ⬇️
Receptorctl 49.31% <ø> (∅)

@thom-at-redhat thom-at-redhat merged commit 137a7aa into ansible:devel Oct 29, 2024
23 of 24 checks passed
@thom-at-redhat thom-at-redhat deleted the fix_command_error_checking branch October 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants