Skip to content

Commit

Permalink
Start using nodejs 20 (#1629)
Browse files Browse the repository at this point in the history
  • Loading branch information
ssbarnea authored Nov 3, 2024
1 parent af70f5c commit dbf4e67
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 11 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -414,12 +414,17 @@ jobs:
with:
fetch-depth: 0

- run: corepack enable
- name: node post install
run: |
corepack enable
npm config set fund false
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: 18
cache: yarn
cache-dependency-path: "**/yarn.lock"
node-version-file: .tool-versions

- name: Download the artifact
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -458,7 +463,9 @@ jobs:
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v4
with:
node-version: 18
cache: yarn
cache-dependency-path: "**/yarn.lock"
node-version-file: .tool-versions
registry-url: "https://registry.npmjs.org"

- run: npm publish --access public @ansible-ansible-language-server-*.tgz
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/dedupe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,14 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
cache: yarn
cache-dependency-path: "**/yarn.lock"
node-version-file: .tool-versions

- name: Enable Corepack
run: corepack enable
- name: node post install
run: |
corepack enable
npm config set fund false
- name: Configure Git
run: |
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
direnv 2.34.0
nodejs 18.19.1
nodejs 20.18.0
# asdf install task latest
task 3.37.2
yarn 1.22.19
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -989,10 +989,10 @@
"engineStrict": true,
"engines": {
"//": "node version affects only development, it does not affect VS Code runtime",
"node": ">=16.0",
"node": ">=20.0",
"npm": "\n\nERROR: Please use yarn instead of npm for this repository.!!!\n\n",
"vscode": "^1.85.0",
"yarn": ">=3.2.1"
"yarn": ">=4.5.1"
},
"extensionDependencies": [
"ms-python.python",
Expand Down
1 change: 0 additions & 1 deletion packages/ansible-language-server/Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ tasks:
desc: Run all tests using node (same version as vscode), will skip @ee tests if both SKIP_PODMAN=1 and SKIP_DOCKER=1.
dir: "{{ .TASKFILE_DIR }}"
cmds:
# - bash -c 'asdf local nodejs latest:18 latest:$(asdf nodejs resolve lts)'
- task: .test
test-node-lts:
dir: "{{ .TASKFILE_DIR }}"
Expand Down
2 changes: 1 addition & 1 deletion packages/ansible-language-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"icon": "icon.png",
"engines": {
"node": ">=14.0",
"node": ">=20.0",
"npm": ">=7.11.2"
},
"bin": "bin/ansible-language-server",
Expand Down

0 comments on commit dbf4e67

Please sign in to comment.