Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-32136: VS Code Extension: Playbook custom_prompt titivation #1554

Merged
merged 1 commit into from
Sep 27, 2024
Merged

AAP-32136: VS Code Extension: Playbook custom_prompt titivation #1554

merged 1 commit into from
Sep 27, 2024

Conversation

manstis
Copy link
Contributor

@manstis manstis commented Sep 27, 2024

Change settings description and add validation.

@manstis manstis requested review from a team as code owners September 27, 2024 09:10
TamiTakamiya
TamiTakamiya approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@TamiTakamiya TamiTakamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

btw, I've read that multiline settings are supported and thought it would be good for those options, but it did not work as far as I tried...

@TamiTakamiya
Copy link
Collaborator

microsoft/vscode#183025 (comment)

It looks like the multilineText support was mentioned in a release note, but it was not actually implemented....

@manstis
Copy link
Contributor Author

manstis commented Sep 27, 2024

@TamiTakamiya

It looks like the multilineText support was mentioned in a release note

It does work.. but it does not render a TextArea.. you can however keep typing and the widget height grows (unlike single line text settings).. I've made the change on this PR. I gleaned this from looking at the source code for it!

@manstis manstis merged commit 225e0d6 into ansible:main Sep 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamiTakamiya TamiTakamiya TamiTakamiya approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
skip-changelog
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manstis @TamiTakamiya