test: use test-launch.sh to run the tests #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
goneri/test-use-test-ui.sh-to-run-the-tests_165
branch
from
fda6b08
to
e79c4ad
Compare
goneri
force-pushed
the
goneri/test-use-test-ui.sh-to-run-the-tests_165
branch
from
e79c4ad
to
def053d
Compare
goneri
force-pushed
the
goneri/test-use-test-ui.sh-to-run-the-tests_165
branch
from
def053d
to
a466a14
Compare
Use one single script called `./tools/test-launch.sh` to trigger all the different tests: - `COVERAGE=1` or `-c` to enable the code coverage - `COVE_VERSION` to set the vscode-extension-tester parameter (e.g `max` or `min`) - `MOCK_LIGHTSPEED_API` (`1` or ``): set it to `1` to dynamically start the mocked server and set `TEST_LIGHTSPEED_URL` - `TEST_TYPE`: `e2e` or `ui` (default) The goal is to reduce the amount of reentrant `yarn` calls and provide a more linar execution flow. Bonus points: - we don't need `start-server-and-test` anymore - we avoid a lot of complexity with how we deal with `TEST_LIGHTSPEED_URL` on MacOS.
goneri
force-pushed
the
goneri/test-use-test-ui.sh-to-run-the-tests_165
branch
from
67af4dc
to
a49d409
Compare
ssbarnea
reviewed
Nov 8, 2024
goneri
commented
Nov 8, 2024
https://github.com/ansible/vscode-ansible/pull/1649/files#r1834505006 |
ssbarnea
approved these changes
Nov 8, 2024
ssbarnea
approved these changes
Nov 8, 2024
TamiTakamiya
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thank you @goneri! This was long due change that I should have made months ago...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one single script called
./tools/test-launch.shto trigger all the different tests:COVERAGE=1or-cto enable the code coverageCOVE_VERSIONto set the vscode-extension-tester parameter (e.gmaxormin)MOCK_LIGHTSPEED_API(1or ``): set it to1to dynamically start the mocked server and set `TEST_LIGHTSPEED_URL`TEST_TYPE:e2eorui(default)The goal is to reduce the amount of reentrant
yarncalls and provide a more linar execution flow.Bonus points:
start-server-and-testanymoreTEST_LIGHTSPEED_URLon MacOS.