Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add more components to the search indexing #541

Merged
merged 38 commits into from
Oct 25, 2024
Merged

fix: add more components to the search indexing #541

merged 38 commits into from
Oct 25, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Oct 10, 2024 •
edited
Loading

fix #540

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Oct 10, 2024
jorgepiloto
jorgepiloto reviewed Oct 16, 2024
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
jorgepiloto
jorgepiloto requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just added some comments and suggestions, @Revathyvenugopal162.

@Revathyvenugopal162 @jorgepiloto
Apply suggestions from code review
908212f 
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
@Revathyvenugopal162
fix: add all init
95ae207
@Revathyvenugopal162
fix: config values
adcbb8a
@jorgepiloto jorgepiloto added this to the v1.2 milestone Oct 18, 2024
jorgepiloto
jorgepiloto reviewed Oct 24, 2024
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
jorgepiloto
jorgepiloto requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some minor comments. Almost ready to be merged.

@Revathyvenugopal162 @jorgepiloto
Apply suggestions from code review
0b7f055 
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
@jorgepiloto jorgepiloto merged commit 5130e1e into main Oct 25, 2024
21 checks passed
@jorgepiloto jorgepiloto deleted the fix/indexing-docs-components branch October 25, 2024 09:57
@jorgepiloto
Copy link
Member

Thanks for adding this, @Revathyvenugopal162!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees
No one assigned
Labels
fix Pull requests related to resolving problems or errors
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Improve indexing of content
4 participants
@Revathyvenugopal162 @jorgepiloto @RobPasMue @pyansys-ci-bot