Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: HFSS Setup error #5618 #5619

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+33 −16
Open

FIX: HFSS Setup error #5618 #5619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8a030b
Correct error to HFSS Setup default type #5618
Devin-Crawford Dec 28, 2024
5a5d215
Update Docs and Unit Tests
Devin-Crawford Jan 3, 2025
f6fa96b
CHORE: Auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 3, 2025
adcd610
Merge branch 'main' into fix/5618_hfss_default_setup
MaxJPRey Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ansys/aedt/core/application/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,8 @@

if setup_type is None:
setup_type = self.design_solutions.default_setup
name = self.generate_unique_setup_name(name)
if not name:
name = self.generate_unique_setup_name(name)

Check warning on line 1359 in src/ansys/aedt/core/application/analysis.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/application/analysis.py#L1358-L1359 

Added lines #L1358 - L1359 were not covered by tests
if setup_type == 0:
setup = SetupHFSSAuto(self, setup_type, name)
elif setup_type == 4:
Expand Down
8 changes: 4 additions & 4 deletions src/ansys/aedt/core/application/design_solutions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,31 +342,31 @@
"name": "HFSS Modal Network",
"options": None,
"report_type": "Modal Solution Data",
"default_setup": 1,
"default_setup": 0,
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
"Terminal": {
"name": "HFSS Terminal Network",
"options": None,
"report_type": "Terminal Solution Data",
"default_setup": 1,
"default_setup": 0,
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
"DrivenModal": {
"name": "DrivenModal",
"options": None,
"report_type": "Modal Solution Data",
"default_setup": 1,
"default_setup": 0,
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
"DrivenTerminal": {
"name": "DrivenTerminal",
"options": None,
"report_type": "Terminal Solution Data",
"default_setup": 1,
"default_setup": 0,
"default_adaptive": "LastAdaptive",
"intrinsics": ["Freq", "Phase"],
},
Expand Down
3 changes: 1 addition & 2 deletions src/ansys/aedt/core/hfss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,8 +811,7 @@ def create_setup(self, name="MySetupAuto", setup_type=None, **kwargs):
``"HFSSDrivenAuto"``, ``"HFSSDrivenDefault"``, ``"HFSSEigen"``, ``"HFSSTransient"``,
and ``"HFSSSBR"``. The default is ``"HFSSDrivenAuto"``.
**kwargs : dict, optional
Extra arguments to set up the circuit.
Available keys depend on the setup chosen.
Keyword arguments from the native AEDT API.
For more information, see
:doc:`../SetupTemplatesHFSS`.

Expand Down
2 changes: 1 addition & 1 deletion src/ansys/aedt/core/modules/setup_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def HFSS3DLayout_AdaptiveFrequencyData(freq):


meshlink = dict({"ImportMesh": False})
autosweep = dict({"RangeType": "LinearStep", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeStep": "1GHz"})
autosweep = dict({"RangeType": "LinearCount", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeCount": "501"})
autosweeps = dict({"Sweep": autosweep})
multifreq = dict({"1GHz": [0.02], "2GHz": [0.02], "5GHz": [0.02]})
sweepsbr = dict({"RangeType": "LinearStep", "RangeStart": "1GHz", "RangeEnd": "10GHz", "RangeStep": "1GHz"})
Expand Down
Loading