Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinate system example retro-compatibility #1747

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

PProfizi
Copy link
Contributor

The modification made here to follow the changes server-side were not retro-compatible with older DPF versions.

@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Sep 16, 2024
@PProfizi PProfizi self-assigned this Sep 16, 2024
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi enabled auto-merge (squash) September 16, 2024 08:56
@PProfizi PProfizi added this to the v0.13.1 milestone Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (a314cd0) to head (077a451).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
+ Coverage   85.64%   87.00%   +1.35%     
==========================================
  Files          83       83              
  Lines        9937     9937              
==========================================
+ Hits         8511     8646     +135     
+ Misses       1426     1291     -135     

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi merged commit 0de17ec into master Sep 16, 2024
39 checks passed
@PProfizi PProfizi deleted the fix/coordinate_system_example_retro branch September 16, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants