-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorials and update User Guide layout #1749
Changes from 9 commits
b07cfa1
bbd357a
06c39d7
3b12114
ab9ec85
bba597b
43728da
5f16ef4
cafd463
93d91ee
c991e28
610a834
33fade6
6a9d9f4
59a08d0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,10 @@ | |
============= | ||
API reference | ||
============= | ||
|
||
.. toctree:: | ||
:maxdepth: 2 | ||
:caption: API reference | ||
|
||
ansys.dpf.core | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -7,7 +7,7 @@ | |||
import pyvista | ||||
from ansys.dpf.core import __version__, server, server_factory | ||||
from ansys.dpf.core.examples import get_example_required_minimum_dpf_version | ||||
from ansys_sphinx_theme import pyansys_logo_black, ansys_favicon, get_version_match | ||||
from ansys_sphinx_theme import pyansys_logo_light_mode, ansys_favicon, get_version_match | ||||
|
||||
# Manage errors | ||||
pyvista.set_error_output_file("errors.txt") | ||||
|
@@ -74,6 +74,7 @@ | |||
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom | ||||
# ones. | ||||
extensions = [ | ||||
"sphinx.ext.autosummary", | ||||
"enum_tools.autoenum", | ||||
"nbsphinx", | ||||
"sphinx.ext.autosectionlabel", | ||||
|
@@ -193,7 +194,7 @@ def reset_servers(gallery_conf, fname, when): | |||
# -- Options for HTML output ------------------------------------------------- | ||||
html_short_title = html_title = "PyDPF-Core" | ||||
html_theme = "ansys_sphinx_theme" | ||||
html_logo = pyansys_logo_black | ||||
html_logo = pyansys_logo_light_mode | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
yes you need to remove this line, and then add "logo":"pyansys", in html theme options. That should work There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just test this variation and it still gives me the same error There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let me try it locally. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, you are correct, and i think it is because of some mismatch in configuration. i can fix with with another workaround and push that changes if its ok for you |
||||
html_favicon = ansys_favicon | ||||
html_theme_options = { | ||||
"github_url": "https://github.com/ansys/pydpf-core", | ||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ | |
Examples | ||
======== | ||
These examples demonstrate the behavior and usage of DPF-Core. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisaFelixSalles why do we need this change? Is it going to work in dark mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current nav bar looks like this:
The logo has a black square background, but we dont see it because the navigation bar also has a black background.:
So, I changed the logo for the one with a light back ground, to match the new navigation bar color. It actually doesn't look good in dark mode, I'll look into other projects to see how they do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Revathyvenugopal162 I would like to ask for your help also in this case:
I tried passing the logo as an html configuration option with:
But I get the following error when building the documentation:
Do you know if I'm missing other configuration changes in other to solve this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wont work with out new theme. Please add this "logo": "pyansys" in theme options. example PR , ansys/pyansys-geometry@40366c1#diff-d8d3ed25802824d15bf411f8e97416d8fc6f9247e821b0617f2b869dc584b99c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but it gives me the same error.
Is there a way to implement the logo (that respects the light and dark modes) with the new theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisaFelixSalles @PProfizi The logo issue was fixed in 33fade6 and this is the first time we are getting this issue. i will keep track on this and try to fix it in ansys sphinx theme if required. The recommended way is using "logo":"pyansys" in theme options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help ! 🙂