Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CORBA interface #2138

Closed
1 of 2 tasks
germa89 opened this issue Jun 22, 2023 · 7 comments · Fixed by #2517
Closed
1 of 2 tasks

Deprecate CORBA interface #2138

germa89 opened this issue Jun 22, 2023 · 7 comments · Fixed by #2517
Assignees
@germa89

Comments

@germa89
Copy link
Collaborator

germa89 commented Jun 22, 2023 •
edited
Loading

Because we are not supporting python 3.7, we should deprecate the CORBA package which does not work for python >=3.8

== EDIT ==

I'm breaking this in two PRs. One now to implement a warning and add documentation about it, and another one in v0.67 where I will effectively deprecate the CORBA interface.
@germa89
Copy link
Collaborator Author

germa89 commented Jun 23, 2023

Pinging @koubaa @FredAns @MaxJPRey for visibility

@koubaa
Copy link
Contributor

koubaa commented Jun 23, 2023

@germa89 I think we should just remove it from the python client

@MaxJPRey
Copy link
Contributor

@germa89 I think we should just remove it from the python client

Yes, if possible, I will remove it.

@FredAns
Copy link
Contributor

FredAns commented Jun 26, 2023

Do someone see any added value for the CORBA API vs the gRPC one ?

@koubaa
Copy link
Contributor

koubaa commented Jun 26, 2023

Do someone see any added value for the CORBA API vs the gRPC one ?

maybe. but even if so.. imho it is not enough value for us to go and maintain a python library for corba ourselves

@germa89
Copy link
Collaborator Author

germa89 commented Jun 29, 2023

Roger...

@germa89
Copy link
Collaborator Author

germa89 commented Jul 31, 2023

Updating issue text.

@germa89 germa89 self-assigned this Aug 11, 2023
@germa89 germa89 mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecating CORBA and Python 3.8 ansys/pymapdl
4 participants
@koubaa @germa89 @FredAns @MaxJPRey