Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansys-mapdl-reader, pyiges and pyvista #2160

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 4, 2023

Bumps ansys-mapdl-reader and pyvista. These dependencies needed to be updated together.
Updates ansys-mapdl-reader from 0.52.16 to 0.52.17

Release notes

Sourced from ansys-mapdl-reader's releases.

v0.52.17

Full Changelog: ansys/pymapdl-reader@v0.52.16...v0.52.17

Commits

Updates pyvista from 0.39.1 to 0.40.0

Release notes

Sourced from pyvista's releases.

v0.40.0

This release is marked by dramatic improvements to PyVista's Trame-powered Jupyter backend, default theming, picking capabilities, and significant maintenance to improve PyVista's long-term sustainability.

What's Changed

Breaking Changes

New Features

Bug fixes or behavior changes

Documentation

Maintenance

... (truncated)

Commits

Updates pyiges from 0.3.0 to 0.3.1

Bumps [ansys-mapdl-reader](https://github.com/pyansys/pymapdl-reader) and [pyvista](https://github.com/pyvista/pyvista). These dependencies needed to be updated together.

Updates `ansys-mapdl-reader` from 0.52.16 to 0.52.17
- [Release notes](https://github.com/pyansys/pymapdl-reader/releases)
- [Commits](ansys/pymapdl-reader@v0.52.16...v0.52.17)

Updates `pyvista` from 0.39.1 to 0.40.0
- [Release notes](https://github.com/pyvista/pyvista/releases)
- [Commits](pyvista/pyvista@v0.39.1...v0.40.0)
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator

germa89 commented Jul 5, 2023

This can be merged when pyvista/pyiges#37 is published into a release (current 0.3.0)

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2160 (c875727) into main (997e288) will increase coverage by 6.30%.
The diff coverage is 96.92%.

@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
+ Coverage   80.82%   87.13%   +6.30%     
==========================================
  Files          44       45       +1     
  Lines        7489     7996     +507     
==========================================
+ Hits         6053     6967     +914     
+ Misses       1436     1029     -407     

@germa89 germa89 changed the title Bump ansys-mapdl-reader and pyvista Bump ansys-mapdl-reader, pyiges and pyvista Jul 6, 2023
@germa89 germa89 enabled auto-merge (squash) July 7, 2023 07:44
@germa89 germa89 disabled auto-merge July 7, 2023 07:46
@germa89
Copy link
Collaborator

germa89 commented Jul 7, 2023

Pinging @jorgepiloto and/or @RobPasMue for feedback on the way I write the dependencies. I believe [project.optional-dependencies] don't allow the definition as the dependencies.

@RobPasMue
Copy link
Member

RobPasMue commented Jul 7, 2023

Pinging @jorgepiloto and/or @RobPasMue for feedback on the way I write the dependencies. I believe [project.optional-dependencies] don't allow the definition as the dependencies.

What's the issue here? Looks like dependabot did its job, right?

@germa89
Copy link
Collaborator

germa89 commented Jul 7, 2023

Pinging @jorgepiloto and/or @RobPasMue for feedback on the way I write the dependencies. I believe [project.optional-dependencies] don't allow the definition as the dependencies.

What's the issue here? Looks like dependabot did its job, right?

Well... I had to add the geomdl and pyiges because it seems you cannot do:

[project.optional-dependencies]
"pyvista[full]>=0.33"

Am I right?

== EDIT ==

Yes you can:
https://github.com/ansys/pygeometry/blob/e2250aa4bbb021eba6dbec5f22c57e6996b7449f/pyproject.toml#L64C9-L64C9

pyproject.toml Outdated Show resolved Hide resolved
@RobPasMue
Copy link
Member

Pinging @jorgepiloto and/or @RobPasMue for feedback on the way I write the dependencies. I believe [project.optional-dependencies] don't allow the definition as the dependencies.

What's the issue here? Looks like dependabot did its job, right?

Well... I had to add the geomdl and pyiges because it seems you cannot do:

[project.optional-dependencies]
"pyvista[full]>=0.33"

Am I right?

== EDIT ==

Yes you can: https://github.com/ansys/pygeometry/blob/e2250aa4bbb021eba6dbec5f22c57e6996b7449f/pyproject.toml#L64C9-L64C9

The main problem is that targets may "disappear" from time to time... For example:
WARNING: pyvista 0.40.0 does not provide the extra 'full'

@germa89
Copy link
Collaborator

germa89 commented Jul 7, 2023

Pinging @jorgepiloto and/or @RobPasMue for feedback on the way I write the dependencies. I believe [project.optional-dependencies] don't allow the definition as the dependencies.

What's the issue here? Looks like dependabot did its job, right?

Well... I had to add the geomdl and pyiges because it seems you cannot do:

[project.optional-dependencies]
"pyvista[full]>=0.33"

Am I right?
== EDIT ==
Yes you can: https://github.com/ansys/pygeometry/blob/e2250aa4bbb021eba6dbec5f22c57e6996b7449f/pyproject.toml#L64C9-L64C9

The main problem is that targets may "disappear" from time to time... For example: WARNING: pyvista 0.40.0 does not provide the extra 'full'

I guess it is a trade we trade we have to do.

@germa89 germa89 enabled auto-merge (squash) July 7, 2023 11:07
@germa89 germa89 merged commit 4540fa1 into main Jul 7, 2023
@germa89 germa89 deleted the dependabot/pip/main/ansys-mapdl-reader-and-pyvista-0.52.17 branch July 7, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants