-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check commit message type before committing #3187
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3187 +/- ##
==========================================
- Coverage 86.63% 84.47% -2.17%
==========================================
Files 52 52
Lines 9550 9596 +46
==========================================
- Hits 8274 8106 -168
- Misses 1276 1490 +214 |
As the action only checks for the PR name, this will make the Edit: as there is no |
Good catch @clatapie OK. I think the Regarding the Although we do not have Let's merge this if there is no failure on CICD. |
|
Agreed - in fact we should standardize it to "chore: ..." IMO |
Yeah... you are not going to come around that one easily 😄 |
History of my life man... xDDD |
I'm closing this PR without merging. Fixing it is more trouble than getting used to the new convention. |
Description
Use
pre-commit
hooks to check commit messages before commiting.Issue linked
N/A
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)