Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an inprocess backend to pymapdl #3198
feat: Add an inprocess backend to pymapdl #3198
Changes from all commits
854de4f
c39e1c9
bb8f1a6
3c0e1bd
f0a3006
4d250af
c1962bd
7127276
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 23 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L23
Check warning on line 25 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L25
Check warning on line 29 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L28-L29
Check warning on line 34 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L32-L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be implemented in
_MapdlCore
. My fault.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be something specific to the grpc backend.
We can try to move it to mapdl_grpc instead and replace these lines by a
_before_run()
command implemented in the children.@koubaa
Check warning on line 41 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L37-L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this one could be also implemented in
_MapdlCore
.Check warning on line 45 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L43-L45
Check warning on line 48 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L47-L48
Check warning on line 50 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L50
Check warning on line 54 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L52-L54
Check warning on line 58 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L56-L58
Check warning on line 61 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L60-L61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go to
_MapdlCore
.Check warning on line 65 in src/ansys/mapdl/core/mapdl_inprocess.py
Codecov / codecov/patch
src/ansys/mapdl/core/mapdl_inprocess.py#L63-L65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not changing anything from
super()
I guess it should be implemented (again) in_MapdlCore
class.